Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on tightening versioned fix documentation + test coverage while delivering a set of chat history / citations improvements and document revisioning behavior (current-only visibility, revision-family deletion choices, and blob archival behavior).
Changes:
- Adds/updates Playwright UI tests and functional regression scripts covering revision-aware delete modals, chat tag resets, agent-citation hydration, and tabular analysis flows.
- Updates frontend + backend to support revision-choice delete modals, enhanced-citation historical metadata fetch, and richer chat history context diagnostics/citation replay.
- Updates fix documentation + release notes and bumps
application/single_app/config.pyto0.240.055.
Reviewed changes
Copilot reviewed 76 out of 89 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| ui_tests/test_workspace_family_document_revision_delete_modal.py | UI coverage for revision delete modal presence (personal/group/public). |
| ui_tests/test_group_workspace_initial_documents_fetch.py | UI regression for initial group docs load + dialog suppression. |
| ui_tests/test_chat_new_conversation_tag_reset.py | UI regression ensuring new conversation clears tag selection state. |
| ui_tests/test_agent_citation_modal_full_results.py | UI regression for lazy-loading full agent citation artifacts + row expansion. |
| functional_tests/test_tabular_preview_json_sanitization_fix.py | Regression for JSON-safe tabular preview serialization and route wiring. |
| functional_tests/test_tabular_multisheet_workbook_support.py | Updates assertions around multi-sheet discovery guidance text. |
| functional_tests/test_tabular_multisheet_tool_start_guidance.py | New regression for multi-sheet discovery iteration + prompt snippets. |
| functional_tests/test_tabular_multi_file_distinct_url_union.py | New regression for deterministic multi-file distinct URL union mode. |
| functional_tests/test_tabular_group_blob_context_and_sheet_whitespace.py | New regression for trailing-space sheet names + group blob reuse. |
| functional_tests/test_tabular_enhanced_citations_schema_summary_fix.py | Regression for bounded schema summary + no fallback to row chunking. |
| functional_tests/test_tabular_author_metadata_normalization_fix.py | Regression for author metadata normalization behavior + wiring. |
| functional_tests/test_tabular_analysis_rejects_discovery_only.py | Updates test expectations for discovery-only rejection messaging. |
| functional_tests/test_tabular_all_scope_group_source_context.py | New regression for preserving per-file group/public source context in all-scope. |
| functional_tests/test_historical_enhanced_citation_revision_rendering_fix.py | New regression for on-demand metadata fetch for historical cited revisions. |
| functional_tests/test_group_workspace_initial_documents_fetch_fix.py | Regression verifying query param rebuild + no delete flow during init. |
| functional_tests/test_fact_memory_streaming_context_fix.py | Regression ensuring fact memory injection parity in streaming vs standard chat. |
| functional_tests/test_document_revision_current_version_fix.py | Regression covering revision family model + current-only visibility + delete modes. |
| functional_tests/test_citation_revision_lookup_fix.py | Regression for citation lookup using exact document id behind chunk metadata. |
| functional_tests/test_chat_scope_tag_filter_fix.py | Regression ensuring tag filter applies across personal/group/public search branches. |
| functional_tests/test_chat_new_conversation_tag_reset.py | Source-level regression for tag UI reset behavior + version assertion. |
| functional_tests/test_chat_citation_page_sort_fix.py | Regression for mixed numeric/text citation page sorting. |
| functional_tests/test_agent_citation_full_results_modal.py | Source-level regression for agent citation artifact endpoint + UI wiring. |
| docs/explanation/release_notes.md | Adds a new top release entry and bug-fix bullets for the PR’s main items. |
| docs/explanation/fixes/TABULAR_REVIEWER_PSEUDO_QUERY_REWRITE_FIX.md | New fix doc. |
| docs/explanation/fixes/TABULAR_REVIEWER_AUTO_FOLLOW_UP_FIX.md | New fix doc. |
| docs/explanation/fixes/TABULAR_PREVIEW_JSON_SANITIZATION_FIX.md | New fix doc. |
| docs/explanation/fixes/TABULAR_MULTISHEET_TOOL_START_GUIDANCE_FIX.md | New fix doc. |
| docs/explanation/fixes/TABULAR_MULTISHEET_LLM_REVIEWER_RECOVERY_FIX.md | New fix doc. |
| docs/explanation/fixes/TABULAR_MULTI_CONDITION_FILTER_FIX.md | New fix doc. |
| docs/explanation/fixes/TABULAR_GROUP_BLOB_CONTEXT_AND_SHEET_WHITESPACE_FIX.md | New fix doc. |
| docs/explanation/fixes/TABULAR_GENERIC_SEARCH_FIX.md | New fix doc. |
| docs/explanation/fixes/TABULAR_GENERAL_COHORT_DISCOVERY_FIX.md | New fix doc. |
| docs/explanation/fixes/TABULAR_EXHAUSTIVE_RESULT_LIMIT_ESCALATION_FIX.md | New fix doc. |
| docs/explanation/fixes/TABULAR_ENHANCED_CITATIONS_SCHEMA_SUMMARY_FIX.md | New/updated fix doc content for schema-summary behavior. |
| docs/explanation/fixes/TABULAR_EMBEDDED_VALUE_EXTRACTION_FIX.md | New fix doc. |
| docs/explanation/fixes/TABULAR_DISTINCT_VALUE_HANDOFF_FIX.md | New fix doc. |
| docs/explanation/fixes/TABULAR_CONTEXTUAL_CELL_SEARCH_FIX.md | New fix doc. |
| docs/explanation/fixes/TABULAR_AUTHOR_METADATA_NORMALIZATION_FIX.md | New fix doc. |
| docs/explanation/fixes/TABULAR_ALL_SCOPE_GROUP_SOURCE_CONTEXT_FIX.md | New fix doc. |
| docs/explanation/fixes/MULTI_FILE_TABULAR_DISTINCT_URL_ANALYSIS_FIX.md | New fix doc for deterministic multi-file distinct URL unions. |
| docs/explanation/fixes/HISTORICAL_ENHANCED_CITATION_REVISION_RENDERING_FIX.md | New fix doc for historical enhanced citation rendering. |
| docs/explanation/fixes/FACT_MEMORY_STREAMING_CONTEXT_FIX.md | New fix doc for streaming fact-memory injection parity. |
| docs/explanation/fixes/DOCUMENT_REVISION_CURRENT_VERSION_FIX.md | New fix doc for revision families/current-only visibility/delete modes. |
| docs/explanation/fixes/CITATION_REVISION_LOOKUP_FIX.md | New fix doc for citation authorization using exact document id. |
| docs/explanation/fixes/CHAT_STREAM_HISTORY_CONTEXT_FIX.md | New fix doc for shared streaming/non-streaming history builder + diagnostics. |
| docs/explanation/fixes/CHAT_SCOPE_TAG_FILTER_FIX.md | New fix doc for scoped tag filtering in hybrid search. |
| docs/explanation/fixes/CHAT_HISTORY_GROUNDED_FOLLOW_UP_FIX.md | New fix doc for persisting last grounded document refs. |
| docs/explanation/fixes/CHAT_CITATION_PAGE_SORT_FIX.md | New fix doc for mixed-type citation page sorting. |
| docs/explanation/fixes/AGENT_TOOL_CITATION_FULL_RESULTS_FIX.md | New fix doc for agent citation raw artifact hydration. |
| artifacts/~$release_timeline.pptx | (Problematic) committed Office temp file. |
| application/single_app/templates/workspace.html | Adds personal workspace revision delete modal markup and registers it in modal init list. |
| application/single_app/templates/public_workspaces.html | Adds public workspace revision delete modal markup. |
| application/single_app/static/js/workspace/workspace-documents.js | Implements revision-choice delete modal flows + delete_mode propagation + bulk delete updates. |
| application/single_app/static/js/public/public_workspace.js | Implements public revision-choice delete modal flows + delete_mode propagation + bulk delete updates. |
| application/single_app/static/js/chat/chat-thoughts.js | Adds icon mapping for history_context thought steps. |
| application/single_app/static/js/chat/chat-messages.js | Adds artifact metadata attrs on agent citations + renders history-context metadata drawer section. |
| application/single_app/static/js/chat/chat-enhanced-citations.js | Fetches historical document metadata on demand before rendering enhanced citation modal. |
| application/single_app/static/js/chat/chat-documents.js | Adds metadata cache + fetchDocumentMetadata + resets tag selection state on rebuild. |
| application/single_app/semantic_kernel_plugins/plugin_invocation_logger.py | Adds structured, compact result summaries (esp. TabularProcessingPlugin) to logging payloads. |
| application/single_app/route_frontend_conversations.py | Adds conversation-scoped endpoint to fetch stored agent citation artifacts. |
| application/single_app/route_external_public_documents.py | Collapses results to current revisions before paginating + adds delete_mode support for external deletes. |
| application/single_app/route_enhanced_citations.py | Adds document-metadata endpoint for historical citations + JSON-safe tabular preview serialization + blob-container/path preference. |
| application/single_app/route_backend_public_documents.py | Collapses list results to current revisions + delete_mode support. |
| application/single_app/route_backend_group_documents.py | Collapses list results to current revisions + delete_mode support. |
| application/single_app/route_backend_documents.py | Collapses list results to current revisions + delete_mode support + revision-aware citation authorization. |
| application/single_app/functions_search.py | Applies revision-family normalization pre-search + tag filtering across scopes + cache gating when normalization changes. |
| application/single_app/functions_conversation_metadata.py | Persists stable last_grounded_document_refs derived from search-backed document usage. |
| application/single_app/config.py | Bumps version to 0.240.055. |
| .gitignore | Ignores artifacts/tmp paths. |
Comments suppressed due to low confidence (1)
docs/explanation/release_notes.md:22
- The release notes add a top section for v0.240.053, but
application/single_app/config.pyis bumped to 0.240.055 in this PR. The latest release-notes heading should match the current config version (or there should be newer sections for 0.240.054/0.240.055 above 0.240.053) so the changelog aligns with what the app reports.
application/single_app/static/js/workspace/workspace-documents.js
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat History Citation Amplification
route_backend_chats.py,functions_message_artifacts.py,chat-thoughts.js,chat-messages.js,test_chat_stream_history_context_fix.py,CHAT_STREAM_HISTORY_CONTEXT_FIX.md)Document Revision Visibility and Storage Preservation
functions_documents.py,functions_search.py,route_enhanced_citations.py, workspace/group/public document flows)