Auto-send buffered stream output in group scope conversations#578
Draft
Copilot wants to merge 5 commits into
Draft
Auto-send buffered stream output in group scope conversations#578Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
Agent-Logs-Url: https://github.com/microsoft/teams.ts/sessions/9987b20f-6ce2-450a-b7fe-67eec7f00efb Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/teams.ts/sessions/9987b20f-6ce2-450a-b7fe-67eec7f00efb Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/teams.ts/sessions/9987b20f-6ce2-450a-b7fe-67eec7f00efb Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/teams.ts/sessions/9987b20f-6ce2-450a-b7fe-67eec7f00efb Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix message sending for group scopes
Auto-send buffered stream output in group scope conversations
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streaming currently requires app authors to branch on
activity.conversation.isGroupand switch fromstream.emit(...)tosend(...)manually. This change moves that behavior into the framework: in group scope, streamed chunks are buffered and emitted as one final message.Behavior change in
HttpStreamfor group scopeConversationReference(conversation.isGroup).close(), sends a single normalmessageactivity with the accumulated text/attachments/entities.channelData.streamTypefrom the final group-scope send so it is not treated as a stream-final payload.Non-group streaming behavior remains unchanged
Focused coverage for new behavior
HttpStreamspec validating that group-scope streaming:Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
incoming-service.botframework.com/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/teams.ts/teams.ts/node_modules/jest-worker/build/workers/processChild.js /sh sh tool�� tsup(dns block)/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/teams.ts/teams.ts/node_modules/jest-worker/build/workers/processChild.js modules/.bin/sh node .ts/�� ./dist/index.d.mts git s/node_modules/.bin/node get --local .ts/packages/apps/node_modules/.git status --porcelain --ignore-submodules | head -n 10 sh /.bi�� tsup git .ts/packages/node_modules/.bin/sh ec.ts src/app.prsh credential.helpe-c p/bin/bash sh(dns block)/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/teams.ts/teams.ts/node_modules/jest-worker/build/workers/processChild.js k/teams.ts/teamsjest sh -c tsup git e_modules/.bin/node HEAD(dns block)service-1.botframework.com/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/teams.ts/teams.ts/node_modules/jest-worker/build/workers/processChild.js /sh sh tool�� tsup(dns block)/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/teams.ts/teams.ts/node_modules/jest-worker/build/workers/processChild.js modules/.bin/sh node .ts/�� ./dist/index.d.mts git s/node_modules/.bin/node get --local .ts/packages/apps/node_modules/.git status --porcelain --ignore-submodules | head -n 10 sh /.bi�� tsup git .ts/packages/node_modules/.bin/sh ec.ts src/app.prsh credential.helpe-c p/bin/bash sh(dns block)/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/teams.ts/teams.ts/node_modules/jest-worker/build/workers/processChild.js k/teams.ts/teamsjest sh -c tsup git e_modules/.bin/node HEAD(dns block)service-2.botframework.com/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/teams.ts/teams.ts/node_modules/jest-worker/build/workers/processChild.js /sh sh tool�� tsup(dns block)/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/teams.ts/teams.ts/node_modules/jest-worker/build/workers/processChild.js modules/.bin/sh node .ts/�� ./dist/index.d.mts git s/node_modules/.bin/node get --local .ts/packages/apps/node_modules/.git status --porcelain --ignore-submodules | head -n 10 sh /.bi�� tsup git .ts/packages/node_modules/.bin/sh ec.ts src/app.prsh credential.helpe-c p/bin/bash sh(dns block)/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/teams.ts/teams.ts/node_modules/jest-worker/build/workers/processChild.js k/teams.ts/teamsjest sh -c tsup git e_modules/.bin/node HEAD(dns block)token.botframework.com/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/teams.ts/teams.ts/node_modules/jest-worker/build/workers/processChild.js /sh sh tool�� tsup(dns block)/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/teams.ts/teams.ts/node_modules/jest-worker/build/workers/processChild.js modules/.bin/sh node .ts/�� ./dist/index.d.mts git s/node_modules/.bin/node get --local .ts/packages/apps/node_modules/.git status --porcelain --ignore-submodules | head -n 10 sh /.bi�� tsup git .ts/packages/node_modules/.bin/sh ec.ts src/app.prsh credential.helpe-c p/bin/bash sh(dns block)/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/teams.ts/teams.ts/node_modules/jest-worker/build/workers/processChild.js k/teams.ts/teamsjest sh -c tsup git e_modules/.bin/node HEAD(dns block)If you need me to access, download, or install something from one of these locations, you can either: