Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ public async Task<int> OrchestrateTestHostExecutionAsync(CancellationToken cance
#if NETCOREAPP
await retryFailedTestsPipeServer.WaitForConnectionAsync(linkedToken2.Token).ConfigureAwait(false);
#else
// We don't know why but if the cancellation is called quickly in line 171 for netfx we stuck sometime here, like if
// We don't know why but if the cancellation is called quickly after adding the pipe name to finalArguments for netfx we stuck sometime here, like if
// the token we pass to the named pipe is not "correctly" verified inside the pipe implementation self.
// We fallback with our custom agnostic cancellation mechanism in that case.
// We see it happen only in .NET FX and not in .NET Core so for now we don't do it for core.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ public void Dispose()
// This is unexpected and we throw an exception.
ApplicationStateGuard.Ensure(_loopTask is not null);

// To close gracefully we need to ensure that the client closed the stream line 103.
// To close gracefully we need to ensure that the client closed the stream in the InternalLoopAsync method.
if (!_loopTask.Wait(TimeoutHelper.DefaultHangTimeSpanTimeout))
{
throw new InvalidOperationException(string.Format(
Expand Down Expand Up @@ -340,7 +340,7 @@ public async ValueTask DisposeAsync()

try
{
// To close gracefully we need to ensure that the client closed the stream line 103.
// To close gracefully we need to ensure that the client closed the stream in the InternalLoopAsync method.
await _loopTask.WaitAsync(TimeoutHelper.DefaultHangTimeSpanTimeout, _cancellationToken).ConfigureAwait(false);
}
catch (TimeoutException)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ private async Task ConsumeAsync()
catch (Exception ex) when (ex is not OperationCanceledException)
{
// If we're draining before to increment the _totalPayloadProcessed we need to signal that we should throw because
// it's possible we have a race condition where the payload check at line 106 return false and the current task is not yet in a
// it's possible we have a race condition where the CompleteAddingAsync payload check returns false and the current task is not yet in a
// "faulted state".
_consumerState.SetException(ex);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private async Task ConsumeAsync()
catch (Exception ex) when (ex is not OperationCanceledException)
{
// If we're draining before to increment the _totalPayloadProcessed we need to signal that we should throw because
// it's possible we have a race condition where the payload check at line 106 return false and the current task is not yet in a
// it's possible we have a race condition where the IsAddingCompleted payload check returns false and the current task is not yet in a
// "faulted state".
_consumerState.SetException(ex);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ public void That_NonGenericCollection_FormatsCorrectly()

public void That_NonGenericCollectionInComparison_FormatsCorrectly()
{
// Arrange - Using ArrayList in a comparison to trigger FormatValue on line 421
// Arrange - Using ArrayList in a comparison to trigger FormatValue method
var arrayList = new ArrayList { 1, 2, 3 };
int[] expectedItems = [1, 2, 3, 4];

Expand Down