Skip to content

Conversation

@alexr00
Copy link
Member

@alexr00 alexr00 commented Jan 28, 2026

Fixes #8378

Copilot AI review requested due to automatic review settings January 28, 2026 10:18
@alexr00 alexr00 enabled auto-merge (squash) January 28, 2026 10:18
@alexr00 alexr00 self-assigned this Jan 28, 2026
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 28, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix issue #8378 where viewing PR descriptions in GitHub Enterprise with Data Residency results in "GraphQL error: Not Found" errors. The fix makes all Enterprise instances fall back to using a simplified GraphQL query (GetChecksWithoutSuite) that omits the checkSuite field.

Changes:

  • Modified error handling in getStatusChecks() to always use the fallback query for Enterprise instances
Comments suppressed due to low confidence (1)

src/github/githubRepository.ts:1671

  • This fix may cause performance degradation for Enterprise instances. The GetChecksWithoutSuite query omits the checkSuite field, which means it doesn't return app information, workflow run details, and event data for CheckRuns (see lines 1097-1108 in queriesShared.gql). This information is used later in the code (lines 1702-1714) to populate workflow names and event details.

For Enterprise instances that do support the checkSuite field, this change forces them to always make incomplete queries, potentially degrading the user experience by losing this contextual information about their checks.

			if (isSamlError(e) || this.remote.isEnterprise) {

@alexr00 alexr00 merged commit 7c31f1d into main Jan 28, 2026
12 checks passed
@alexr00 alexr00 deleted the alexr00/leading-thrush branch January 28, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error viewing PR descriptions in ghe

3 participants