Better word detection. Simpler splitting code.#15
Open
atnbueno wants to merge 2 commits intomicrosoft:mainfrom
Open
Better word detection. Simpler splitting code.#15atnbueno wants to merge 2 commits intomicrosoft:mainfrom
atnbueno wants to merge 2 commits intomicrosoft:mainfrom
Conversation
* Was the `/(< ([^>]+)<)/g` regex trying to delete HTML tags? If so, I fixed it * The two last replacements do the same as `.trim()` * With `normalize`+`replace` words with diacritics are counted properly. Not perfect, but usually enough for a few languages.
This was referenced Mar 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/(< ([^>]+)<)/gregex trying to delete HTML tags? If so, I fixed it.trim()normalize+replacewords with diacritics are counted properly. Not perfect, but usually enough for a few languages.Fixes #13 and #14 (and not only for Spanish)