Auto-approve writes to null device files (/dev/null, $null, NUL) #276263
+39
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes to null device files were incorrectly requiring approval when
chat.tools.terminal.blockDetectedFileWritesis set tooutsideWorkspace. These are OS-provided device files that safely discard data and should not trigger workspace boundary checks.Changes:
_isSafeNullDevicePath()to identify null devices across platforms:/dev/null(Unix/Linux)NUL(Windows CMD, case-insensitive)$null(PowerShell)_getResult()to skip workspace validation for null device paths, checked before variable detection to handle$null's$characterFixes the scenario shown in the issue where
2>/dev/nulltriggers an unnecessary approval prompt.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
redirector.gvt1.com/proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --crashpad-handler-pid=16574 --enable-crash-reporter=1c02c580-0355-4167-9847-bfd381c0e1a4,no_channel --user-data-dir=/tmp/vscode-tests-1762606799440 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,16173230850607296853,14407152185923085611,262144 --enable-features=PdfUseShowSaveFilePicker --disable-features=ScreenAIOCREnabled,SpareRendererForSitePerProcess --variations-seed-version(dns block).build/electron/code-oss test/unit/electron/index.js --crash-reporter-directory=/home/REDACTED/work/vscode/vscode/.build/crashes --grep CommandLineFileWriteAnalyzer(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.