Skip to content

Conversation

@mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Nov 10, 2025

For #274723

Copilot AI review requested due to automatic review settings November 10, 2025 22:03
@mjbvz mjbvz enabled auto-merge November 10, 2025 22:03
@vs-code-engineering
Copy link

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@rzhao271

Matched files:

  • src/vs/workbench/contrib/preferences/browser/preferences.contribution.ts

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused args parameters from various action run methods across the codebase to improve code clarity and address issue #274723.

Key Changes:

  • Removed unused args: any parameters from 9 action methods
  • Changed one args: any parameter to args: unknown in PasteSelectionClipboardAction

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
preferences.contribution.ts Removed args: any parameter from two run methods that don't use args
selectionClipboard.ts Changed args: any to args: unknown in PasteSelectionClipboardAction (but parameter is still unused)
wordHighlighter.ts Removed args: any parameter from TriggerWordHighlightAction run method
unicodeHighlighter.ts Removed args: any parameter from five action run methods
findController.ts Removed args: any parameter from MoveToMatchFindAction run method

}

public async run(accessor: ServicesAccessor, editor: ICodeEditor, args: any): Promise<void> {
public async run(accessor: ServicesAccessor, editor: ICodeEditor, args: unknown): Promise<void> {
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The args parameter is changed from any to unknown but is never used in the method body. For consistency with the other changes in this PR (which completely remove unused args parameters), this parameter should be removed entirely rather than just changing its type.

Suggested change
public async run(accessor: ServicesAccessor, editor: ICodeEditor, args: unknown): Promise<void> {
public async run(accessor: ServicesAccessor, editor: ICodeEditor): Promise<void> {

Copilot uses AI. Check for mistakes.
@mjbvz mjbvz merged commit aa158dd into microsoft:main Nov 10, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants