Fix: Prevent terminal find highlight from overwriting clipboard for CopyOnSelection (#272894) #276641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #272894 where the terminal's copyOnSelection feature would unintentionally select matches from command-f search and overwrite the clipboard when the find widget highlights search results. Previously, programmatic selections caused by search highlights were treated the same as user selections, triggering the copy-on-selection behavior.
How it fixes the issue
TerminalClipboardContributionto detect when the FindWidget is active.How to test
terminal.integrated.copyOnSelectionis enabled.