-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Support contribution to chat execute menu (for contributed agents) #276661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we first have a discussion and plan for how we envision the delegation to work? In my mind it should go into the send-dropdown but offer a way to promote actions back to the top if the user wants to.
For reference, the dropdown was removed in #271950
rebornix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bpasero yep for sure. I'm not keen on having the delegate button (but mostly want to self host if it ever makes sense for CLI). One thing worth mentioning that CLI has a different gesture for "delegate". The last time when I tried it, it sends request to the cloud, and clears the whole local CLI session. It's a big surprise to me at the time.
|
I would like delegation to work like this, no matter where you delegate to:
|
Co-authored-by: rebornix <[email protected]>
Co-authored-by: rebornix <[email protected]>
…orktree-changes Add uncommitted changes migration to git.createWorktreeWithDefaults
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for contributing to the chat execute menu for contributed agents and includes refactoring of git worktree migration logic.
- Adds a new
chat/executemenu contribution point under thechatSessionsProviderproposed API - Refactors git worktree migration code to eliminate duplication and add support for migrating uncommitted changes when creating worktrees
- Extracts common stash migration logic into a reusable method with parameterized source/target repositories
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/services/actions/common/menusExtensionPoint.ts | Adds the chat/execute menu entry to the extension point registry for supporting chat execute menu contributions under the proposed chatSessionsProvider API |
| extensions/git/src/commands.ts | Refactors worktree migration logic by extracting duplicate code into migrateStashBetweenRepositories, adds new migrateChangesToWorktree method, and extends createWorktreeWithDefaults to optionally migrate uncommitted changes to newly created worktrees |
No description provided.