Skip to content

Conversation

@rebornix
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings November 11, 2025 06:04
@rebornix rebornix enabled auto-merge (squash) November 11, 2025 06:04
@rebornix rebornix self-assigned this Nov 11, 2025
Copilot finished reviewing on behalf of rebornix November 11, 2025 06:05
@vs-code-engineering vs-code-engineering bot added this to the November 2025 milestone Nov 11, 2025
@rebornix rebornix requested review from joshspicer and removed request for Copilot November 11, 2025 06:06
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we first have a discussion and plan for how we envision the delegation to work? In my mind it should go into the send-dropdown but offer a way to promote actions back to the top if the user wants to.

For reference, the dropdown was removed in #271950

Copy link
Member Author

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpasero yep for sure. I'm not keen on having the delegate button (but mostly want to self host if it ever makes sense for CLI). One thing worth mentioning that CLI has a different gesture for "delegate". The last time when I tried it, it sends request to the cloud, and clears the whole local CLI session. It's a big surprise to me at the time.

@bpasero
Copy link
Member

bpasero commented Nov 11, 2025

I would like delegation to work like this, no matter where you delegate to:

  • your local chat remains functional and visible
  • you see a response in that chat that something was delegated (and a link to open the task)
  • a new agentic session appears in the view reporting progress
  • NO editor opens automatically unless I do a user action

Copilot AI review requested due to automatic review settings November 13, 2025 00:38
@vs-code-engineering
Copy link

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • extensions/git/src/commands.ts

Copilot finished reviewing on behalf of rebornix November 13, 2025 00:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for contributing to the chat execute menu for contributed agents and includes refactoring of git worktree migration logic.

  • Adds a new chat/execute menu contribution point under the chatSessionsProvider proposed API
  • Refactors git worktree migration code to eliminate duplication and add support for migrating uncommitted changes when creating worktrees
  • Extracts common stash migration logic into a reusable method with parameterized source/target repositories

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/vs/workbench/services/actions/common/menusExtensionPoint.ts Adds the chat/execute menu entry to the extension point registry for supporting chat execute menu contributions under the proposed chatSessionsProvider API
extensions/git/src/commands.ts Refactors worktree migration logic by extracting duplicate code into migrateStashBetweenRepositories, adds new migrateChangesToWorktree method, and extends createWorktreeWithDefaults to optionally migrate uncommitted changes to newly created worktrees

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants