Remove web worker support from microsoft-authentication extension #276762
+6
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove browser entry point from package.json - Remove browser webpack configuration - Remove browser-specific scripts (compile-web, watch-web) - Remove src/browser/ directory with browser-specific implementations - Remove ExtensionHost.WebWorker enum value - Remove supportsWebWorkerExtensionHost flags from all flows - Simplify authProvider.ts by removing web worker detection logic - Remove web worker test case from flows.test.ts - Successfully compiled with 0 errors Co-authored-by: TylerLeonhardt <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes web worker support from the microsoft-authentication extension, simplifying the codebase to support only remote and local extension hosts. The removal is justified as vscode.dev now implements a compliant msal.js version and the web worker implementation had minimal usage.
Key Changes:
- Removed the
WebWorkerextension host type from the enum and all related support infrastructure - Deleted all browser-specific implementation files that provided stub/alternative implementations for web workers
- Simplified the flow selection logic by replacing a switch statement with a simpler conditional check
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tsconfig.json |
Removed WebWorker library reference from TypeScript compilation |
package.json |
Removed browser entry point and web compilation scripts |
.vscodeignore |
Removed reference to deleted webpack config file |
src/node/flows.ts |
Removed WebWorker enum value, supportsWebWorkerExtensionHost flags, and simplified extension host checking logic |
src/node/authProvider.ts |
Simplified extension host detection by removing browser environment check |
src/node/test/flows.test.ts |
Removed test case for web worker extension host |
src/browser/authProvider.ts |
Deleted stub implementation for browser environment |
src/browser/buffer.ts |
Deleted browser-specific base64 encoding/decoding utilities |
src/browser/fetch.ts |
Deleted browser fetch export |
src/browser/authServer.ts |
Deleted stub server implementation for browser |
extension-browser.webpack.config.js |
Deleted webpack configuration for browser bundle |
dmitrivMS
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate web worker support and related configurations from the microsoft-authentication extension. This change simplifies the codebase by removing unnecessary browser-specific logic and files. The extension now focuses solely on remote and local environments.
This was removed because:
It's a stepping stone for removing classic implementation as well.