fix(extensions): allow extensionButton.prominentBackground to take effect #276788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inent-button-background
Copilot finished reviewing on behalf of
bibaswan-bhawal
November 11, 2025 19:35
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a CSS cascade bug where !important declarations on base extension button styles were preventing more specific .prominent class selectors from applying theme-defined styles for prominent extension actions (like the Install button).
Key Changes:
- Removed
!importantfrom three base extension button CSS properties to allow proper cascade based on selector specificity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a CSS cascade bug that prevented theme authors from styling the "prominent" extension action (e.g. the Install button) via the
extensionButton.prominentBackgroundtoken.Fixes #276781