SCM - more querySelector removal #276790
Merged
SCM - more querySelector removal #276790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
approved these changes
Nov 11, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors DOM element access in the SCM (Source Control Management) component by replacing querySelector calls with direct DOM traversal methods. The goal is to remove restricted syntax usage and improve code maintainability.
Key changes:
- Replaced
querySelector('.monaco-tl-twistie')with saferpreviousElementSiblingaccess - Added defensive checks to validate DOM structure before applying classes
- Improved comment formatting from "hack" to "HACK"
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scmViewPane.ts | Updated three renderer classes (ActionButtonRenderer, InputRenderer, ResourceGroupRenderer) to use previousElementSibling instead of querySelector |
| scmRepositoryRenderer.ts | Updated RepositoryRenderer to use previousElementSibling instead of querySelector |
| scmHistoryViewPane.ts | Updated two renderer classes (HistoryItemRenderer, HistoryItemLoadMoreRenderer) to add defensive checks that were previously missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.