fetch: auto-approve mentioned urls #276987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrivMS
reviewed
Nov 12, 2025
|
|
||
| const invalid = [...Array.from(invalidUris), ...additionalInvalidUrls]; | ||
| const urlsNeedingConfirmation = [...webUris.values(), ...validFileUris]; | ||
| const urlsNeedingConfirmation = new ResourceSet([...webUris.values(), ...validFileUris]); |
Contributor
There was a problem hiding this comment.
Should this pass some comparer to be case-insensitive?
connor4312
force-pushed
the
connor4312/fetch-mentioned-urls
branch
from
70ce322 to
9c66c5c
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements auto-approval for URLs that users have mentioned in their chat messages, reducing unnecessary confirmation prompts when the fetch tool is invoked for URLs the user has already referenced.
Key changes:
- Changed
urlsNeedingConfirmationfrom an array to aResourceSetfor better URI handling - Added auto-approval logic that checks if URLs were mentioned in user messages
- Updated all array operations to work with the new
ResourceSetstructure usingIterableutilities
bpasero
approved these changes
Nov 12, 2025
Tyriar
approved these changes
Nov 12, 2025
Comment on lines
+728
to
+732
| const tool = new FetchWebPageTool( | ||
| new TestWebContentExtractorService(new ResourceMap<string>()), // Empty - all web requests fail | ||
| new ExtendedTestFileService(new ResourceMap<string | VSBuffer>()), // Empty - all file , | ||
| new MockTrustedDomainService([]), | ||
| new MockChatService(), |
Member
There was a problem hiding this comment.
Lots of repetition, could TestInstantiationService help here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #276955