Disclaimer when eligibleForAutoApproval halts tool call
#277592
Merged
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@connor4312 i think it's ok to add my |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a disclaimer message to tool confirmation dialogs when the eligibleForAutoApproval setting restricts a tool from being auto-approved. The disclaimer informs users which setting is preventing auto-approval.
Key changes:
- Adds a disclaimer field to confirmation messages for tools that are not eligible for auto-approval
- Updates the UI rendering logic to display disclaimers when present
- Changes the default confirmation message text from "Run the" to "Run the '{0}' tool?"
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/languageModelToolsService.ts | Adds disclaimer to tool confirmation messages when isEligibleForAutoApproval is false, showing which setting restricts auto-approval |
| src/vs/workbench/contrib/chat/browser/chatContentParts/toolInvocationParts/chatToolConfirmationSubPart.ts | Updates rendering logic to use the complex rendering path (instead of simple string) when a disclaimer is present |
bpasero
approved these changes
Nov 15, 2025
joshspicer
deleted the
joshspicer/disclaimer-isToolEligibleForAutoApproval
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://github.com/microsoft/vscode-internalbacklog/issues/6255