-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Uninstaller Switches and Success Codes to Manifest Schema #5734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
JohnMcPMS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like adding all of these to the schema without an implementation and/or plan on how to consume them will result in values that are unusable. Silent already has a meaning since there is silent ARP entry data. What do we do if a silent switch is present with that ARP data? Interactive is the default assumption for uninstall ARP command line; when would we use the interactive switch?
If they exist in 1.12 schema but aren't implemented, people can add them without effect until they suddenly light up at some point in the future. This is really the blocking issue to me. I can imagine a path forward, even if it isn't clearly defined today, for all of the switches. But allowing for these to be defined in manifests in winget-pkgs without any validation beyond "the manifest parses" seems very bad.
src/AppInstallerRepositoryCore/Rest/Schema/1_12/Json/ManifestDeserializer_1_12.cpp
Show resolved
Hide resolved
I thought the default was:
|
I wasn't complete enough in my statement: Interactive is the default assumption for the UninstallString value behavior. |
Motivated by issue #1885 but does not complete it.
This adds the UninstallerSwitches and UninstallerSuccessCodes to the manifest schema for 1.12 and all related tests and validation.
Neither of these fields are consumed yet, this is updating the schema to support their addition.
Tested:
Microsoft Reviewers: Open in CodeFlow