Feature: feature to ensure clock never gets ahead of external clock source (if eg external clock goes away unexpectedly)#61
Open
doctea wants to merge 19 commits intomidilab:developfrom
Conversation
…ue), to make this behaviour optional
Merge branch 'develop' into feature-strick-external-aug4
…nges to recompile with other branches, to ease A/B testing.
v2.3.0 Release merge from develop branch
Owner
|
Hey @doctea It took some time but the release is up! How did you test the code against external environment so far? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Congrats on 2.3 release @midilab ! :D
This patch needs further testing, but provides the option to ensure that uClock doesn't continue playing if it is in external clock mode and the external clock stops ticking (eg, if cable is unplugged, host device crashes, etc).
This is essential to ensure that devices using uClock and synced to external clocks behave the same way as other devices and sequencers that respond to analogue clock pulses (commercial devices manufactured by eg Behringer, Modal, Arturia, DIY/open-source projects and pre-2.3 uClock devices).
This behaviour mode means that if the external clock pulses stop coming for any reason then the uClock device will wait patiently for the next clock without progressing - instead of the default behaviour of continuing to run its internal clock at the last detected BPM.
This also means that uClock devices can never get significantly ahead of the external master clock (can only get ahead of the external clock by a length of time slightly under the duration of just one note).