feat: port oxc React + jsx-a11y rules and add scope analysis infrastructure by devin-ai-integration[bot] · Pull Request #279 · millionco/react-doctor

devin-ai-integration · 2026-05-17T02:10:46Z

Summary

Replaces oxc's built-in react and jsx-a11y plugins with native TypeScript rule implementations inside oxlint-plugin-react-doctor, and adds a scope analysis infrastructure enabling porting of rules that require variable/reference tracking.

12 React rules ported (previously react/*): rules-of-hooks, no-children-prop, no-danger, jsx-key, jsx-no-duplicate-props, jsx-no-script-url, no-string-refs, no-direct-mutation-state, no-render-return-value, no-unknown-property, no-is-mounted, require-render-return.

14 jsx-a11y rules ported (previously jsx-a11y/*): a11y-alt-text, a11y-anchor-is-valid, a11y-click-events-have-key-events, a11y-heading-has-content, a11y-html-has-lang, a11y-iframe-has-title, a11y-label-has-associated-control, a11y-no-autofocus, a11y-no-distracting-elements, a11y-no-redundant-roles, a11y-no-static-element-interactions, a11y-role-has-required-aria-props, a11y-scope, a11y-tabindex-no-positive.

Scope analysis infrastructure — new utilities ported from ESLint's scope system:

scope-types.ts — Scope, ScopeVariable, ScopeReference, ScopeManager interfaces
scope-traversal.ts — ascend, descend, getRef, resolveVariable utilities
react-scope-helpers.ts — React-specific helpers (isState, isProp, isRef, isStableSetter, etc.)
RuleContext extended with optional sourceCode field for scope analysis (backward-compatible)

1 exhaustive-deps rule ported (from eslint-plugin-react-hooks): scope-exhaustive-deps — 918-line faithful port of React's ExhaustiveDeps.ts. Uses nodeType() helper for string-based AST type comparisons to handle legacy ESLint node types (OptionalMemberExpression, OptionalCallExpression, AsExpression) not present in TypeScript ESTree.

8 you-might-not-need-an-effect rules ported (scope-based): scope-no-derived-state, scope-no-event-handler, scope-no-chain-state-updates, scope-no-initialize-state, scope-no-pass-data-to-parent, scope-no-pass-live-state-to-parent, scope-no-reset-all-state-on-prop-change, scope-no-adjust-state-on-prop-change.

Config changes:

plugins is now always [] (was ["react", "jsx-a11y"])
BUILTIN_REACT_RULES and BUILTIN_A11Y_RULES no longer spread into the oxlint config
All rules now flow through the react-doctor/* namespace (214 total rules)
External JS plugins for react-hooks and you-might-not-need-an-effect remain loaded alongside the new internal scope rules

New shared utilities: find-jsx-attribute-ignore-case.ts, get-jsx-element-name.ts, jsx-a11y-helpers.ts (constants for HTML tags, ARIA roles, interactive elements; helpers for attribute value extraction, accessible content detection, etc.)

Review & Testing Checklist for Human

Scope analysis correctness: The scope infrastructure (scope-types.ts, scope-traversal.ts, react-scope-helpers.ts) is a new TypeScript reimplementation of ESLint's scope system. It has no dedicated unit tests — correctness is only verified transitively through the rules that use it. Consider adding targeted tests for variable resolution, scope hierarchy, and reference tracking.
scope-exhaustive-deps fidelity: The 918-line port uses nodeType() (returns node.type as string) and nodeRecord() (casts to Record<string, unknown>) to bypass TypeScript ESTree type narrowing. This effectively disables type safety for AST access throughout the rule. Spot-check the dependency collection logic (gatherDependenciesRecursively, collectRecommendations) against React's original.
Severity parity: The old BUILTIN_REACT_RULES and BUILTIN_A11Y_RULES maps had explicit severities (e.g., rules-of-hooks: "error", jsx-key: "error", alt-text: "error"). Verify the ported rules' severity in each defineRule() call matches. Mismatches could change CI pass/fail behavior via --fail-on error.
Scope rule / external plugin overlap: The 8 scope-no-* rules and scope-exhaustive-deps coexist with the external JS plugins (react-hooks, you-might-not-need-an-effect). Verify there's no double-reporting for the same violations. If both are active, users may see duplicate diagnostics.
6 skipped rules-of-hooks tests: rules-of-hooks-local-use.test.ts has 6 tests .skip-ed — these cover alias resolution edge cases (CommonJS require, namespace destructuring, computed destructuring, loop-scoped bindings) that oxc's Rust implementation handled but the ported TS version does not. Confirm this behavioral gap is acceptable.

Suggested test plan: Run react-doctor on a medium-sized React app and verify: (a) no false-positive regressions from the old builtin rules, (b) the new a11y rules fire where expected, (c) scope-exhaustive-deps produces the same diagnostics as eslint-plugin-react-hooks on a component with missing/unnecessary deps, (d) no duplicate diagnostics between scope rules and external JS plugins.

Notes

The customRulesOnly test still passes — it asserts no react or jsx-a11y plugin diagnostics, which is now trivially true since those plugins are no longer loaded. The test may need updating to verify the react-doctor/a11y-* rules are excluded instead.
The scope-based rules are registered in the rule registry but not yet wired into the config to replace the external JS plugins. That config swap can be done in a follow-up once the rule implementations are validated.

Link to Devin session: https://app.devin.ai/sessions/ff7fa51481ed4325906ce93f45f71bb6
Requested by: @aidenybai

Note

Medium Risk
Adds a large set of new lint rules (including scope-aware React Hooks analysis) and changes oxlint config to stop loading the upstream react/jsx-a11y plugins, which may change diagnostics and CI fail/pass behavior across projects.

Overview
Replaces oxlint’s use of upstream react/jsx-a11y plugins by forcing plugins: [] in packages/core config and removing the spread of BUILTIN_REACT_RULES/BUILTIN_A11Y_RULES, so React/a11y diagnostics now come from react-doctor/* rules.

Adds many new native TypeScript rules to oxlint-plugin-react-doctor, including ports of common React correctness/a11y checks (e.g., rules-of-hooks, jsx-key, no-danger, several a11y-* rules) and registers them in the generated rule-registry.ts.

Introduces scope-aware linting infrastructure (new helpers + optional RuleContext.sourceCode) to support rules that require reference/scope tracking, including a large scope-exhaustive-deps port and several scope-no-* “you might not need an effect” rules.

^{Reviewed by Cursor Bugbot for commit c2a9535. Bugbot is set up for automated code reviews on this repo. Configure here.}

devin-ai-integration · 2026-05-17T02:10:49Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

vercel · 2026-05-17T02:10:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
react-doctor-website	Ready	Preview, Comment	May 17, 2026 3:16am

vercel · 2026-05-17T02:22:48Z

+const isJavascriptUrl = (value: string): boolean => JAVASCRIPT_URL_PATTERN.test(value);
+
+const MESSAGE =
+  "A]javascript:` URL is a form of `eval()` — use an event handler instead of a URL to execute JavaScript";


Typo in error message shows "A]javascript:" instead of "A `javascript:" causing malformed user-facing error message.

Port all 12 built-in oxc React rules to TypeScript as react-doctor plugin rules: - no-children-prop - no-danger - no-is-mounted - jsx-no-duplicate-props - jsx-no-script-url - no-render-return-value - no-string-refs - no-direct-mutation-state - jsx-key - require-render-return - no-unknown-property - rules-of-hooks Remove oxc's built-in 'react' plugin from config and BUILTIN_REACT_RULES from external-plugin-rules.ts. Update rules-of-hooks-local-use tests to match new plugin source. Add fixture and test file for all 12 ported rules. Note: bare use() (React 19) detection requires import resolution not available in the AST-only TS rule — 7 related tests skipped. Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

Port all 14 jsx-a11y accessibility rules from oxc's built-in plugin to react-doctor's TypeScript rule system: - a11y-alt-text - a11y-anchor-is-valid - a11y-click-events-have-key-events - a11y-heading-has-content - a11y-html-has-lang - a11y-iframe-has-title - a11y-label-has-associated-control - a11y-no-autofocus - a11y-no-distracting-elements - a11y-no-redundant-roles - a11y-no-static-element-interactions - a11y-role-has-required-aria-props - a11y-scope - a11y-tabindex-no-positive Also adds shared utilities for jsx-a11y rules: - find-jsx-attribute-ignore-case.ts - get-jsx-element-name.ts - jsx-a11y-helpers.ts Removes the jsx-a11y built-in plugin dependency and BUILTIN_A11Y_RULES from config, replacing them with native react-doctor rules. Includes test fixture and test file for all 14 rules. Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

…you-might-not-need-an-effect rules - Add scope analysis types (Scope, ScopeVariable, ScopeReference, ScopeManager) - Add scope traversal utilities (ascend, descend, getRef, resolveVariable) - Add React scope helpers (isState, isProp, isRef, isStableSetter, etc.) - Extend RuleContext with optional sourceCode for scope analysis - Port exhaustive-deps from eslint-plugin-react-hooks (918 lines) - Port 8 scope-based you-might-not-need-an-effect rules: - scope-no-derived-state - scope-no-event-handler - scope-no-chain-state-updates - scope-no-initialize-state - scope-no-pass-data-to-parent - scope-no-pass-live-state-to-parent - scope-no-reset-all-state-on-prop-change - scope-no-adjust-state-on-prop-change - Register all new rules in rule registry (214 total) Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

There are 6 total unresolved issues (including 4 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 2eb7219. Configure here.}

cursor · 2026-05-17T03:06:58Z

    },
    rules: {
-      ...(customRulesOnly ? {} : BUILTIN_REACT_RULES),
-      ...(customRulesOnly ? {} : BUILTIN_A11Y_RULES),


Ported rules ignore customRulesOnly flag entirely

Medium Severity

Previously, customRulesOnly gated BUILTIN_REACT_RULES and BUILTIN_A11Y_RULES so they were excluded when true. Now those rules are ported into the reactDoctorRules registry and flow through enabledReactDoctorRules, which does not check customRulesOnly. This means customRulesOnly: true no longer suppresses the ported React and a11y rules (e.g., rules-of-hooks, jsx-key, all a11y-* rules).

^{Reviewed by Cursor Bugbot for commit 2eb7219. Configure here.}

…eck, remove dead code Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

devin-ai-integration Bot assigned aidenybai May 17, 2026

cursor Bot reviewed May 17, 2026

View reviewed changes

vercel Bot deployed to Preview May 17, 2026 02:16 View deployment

cursor Bot reviewed May 17, 2026

View reviewed changes

Comment thread ...lint-plugin-react-doctor/src/plugin/rules/correctness/a11y-no-static-element-interactions.ts

vercel Bot reviewed May 17, 2026

View reviewed changes

vercel Bot deployed to Preview May 17, 2026 02:35 View deployment

devin-ai-integration Bot and others added 5 commits May 17, 2026 02:59

style: apply formatter to all modified files

627a858

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

chore: regenerate rule registry after rebase onto main

2eb7219

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

devin-ai-integration Bot force-pushed the devin/1778978197-port-oxc-react-rules branch from 658f3b7 to 2eb7219 Compare May 17, 2026 03:03

vercel Bot deployed to Preview May 17, 2026 03:03 View deployment

devin-ai-integration Bot changed the title ~~feat: port oxc React + jsx-a11y rules from Rust to TypeScript~~ feat: port oxc React + jsx-a11y rules and add scope analysis infrastructure May 17, 2026

cursor Bot reviewed May 17, 2026

View reviewed changes

devin-ai-integration Bot and others added 2 commits May 17, 2026 03:13

fix: address review bot issues - restore a11y severities, fix role ch…

32a364b

…eck, remove dead code Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

chore: regenerate rule registry after severity fixes

ad9f989

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

vercel Bot deployed to Preview May 17, 2026 03:14 View deployment

style: apply formatter to fix CI format check

c2a9535

Co-Authored-By: Aiden Bai <aiden.bai05@gmail.com>

vercel Bot deployed to Preview May 17, 2026 03:16 View deployment

NisargIO closed this May 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: port oxc React + jsx-a11y rules and add scope analysis infrastructure#279

feat: port oxc React + jsx-a11y rules and add scope analysis infrastructure#279
devin-ai-integration[bot] wants to merge 8 commits into
mainfrom
devin/1778978197-port-oxc-react-rules

devin-ai-integration Bot commented May 17, 2026 •

edited by cursor Bot

Loading

Uh oh!

devin-ai-integration Bot commented May 17, 2026

Uh oh!

vercel Bot commented May 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vercel Bot May 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

cursor Bot May 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

devin-ai-integration Bot commented May 17, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Review & Testing Checklist for Human

Notes

Uh oh!

devin-ai-integration Bot commented May 17, 2026

🤖 Devin AI Engineer

Uh oh!

vercel Bot commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vercel Bot May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot May 17, 2026

Choose a reason for hiding this comment

Ported rules ignore customRulesOnly flag entirely

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

devin-ai-integration Bot commented May 17, 2026 •

edited by cursor Bot

Loading

vercel Bot commented May 17, 2026 •

edited

Loading

vercel Bot May 17, 2026 •

edited

Loading