Fix PIBD sync stuck #3817
Open
Fix PIBD sync stuck #3817
+320
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 30, 2025
DavidBurkett
reviewed
Jan 6, 2026
DavidBurkett
reviewed
Jan 6, 2026
DavidBurkett
reviewed
Jan 6, 2026
DavidBurkett
reviewed
Jan 6, 2026
| /// How long the state sync should wait after requesting a segment from a peer before | ||
| /// deciding the segment isn't going to arrive. The syncer will then re-request the segment | ||
| pub const SEGMENT_REQUEST_TIMEOUT_SECS: i64 = 60; | ||
| pub const SEGMENT_REQUEST_TIMEOUT_SECS: i64 = 20; |
Member
There was a problem hiding this comment.
This may be okay, but we do have a lot of slow peers on the network and the rangeproof segments can be kind of large IIUC. It'd be a good idea to look for someone with a slow connection to test this change and make sure we aren't causing needless churn with the timeout reduction.
Contributor
Author
There was a problem hiding this comment.
OK, will try to simulate slow connection to see the difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @wiesche89.