Skip to content

Fork detection script #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ImplOfAnImpl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fork detection script #1968

ImplOfAnImpl wants to merge 2 commits into from

Conversation

@ImplOfAnImpl
Copy link
Contributor

@ImplOfAnImpl ImplOfAnImpl commented Sep 11, 2025 •
edited
Loading

I've been running this script for a couple of months now, it works reasonably well.

Some unrelated minor changes are also in this PR:

  1. The parameter --from_height in the chainstate dumper was renamed to --from-height, for consistency.
  2. The logging of "Stale block received" in chainstate was removed (it was intended to be used in the fork detector, but I ended up not needing it).
  3. Fixed spurious failure in the unsupported_message test in p2p (got the failure in another PR).

@ImplOfAnImpl ImplOfAnImpl mentioned this pull request Sep 22, 2025
Merged
@ImplOfAnImpl ImplOfAnImpl changed the base branch from difficulty_plot_helpers to fork_detection_script_deps September 22, 2025 09:33
Base automatically changed from fork_detection_script_deps to master September 25, 2025 15:25
@ImplOfAnImpl ImplOfAnImpl force-pushed the fork_detection_script branch from 305fbe6 to 998cf39 Compare October 3, 2025 15:57
@ImplOfAnImpl ImplOfAnImpl force-pushed the fork_detection_script branch from 998cf39 to 4b860c6 Compare October 24, 2025 16:37
@ImplOfAnImpl ImplOfAnImpl changed the base branch from master to make_ptx_an_enum November 26, 2025 14:08
@ImplOfAnImpl ImplOfAnImpl marked this pull request as ready for review November 26, 2025 14:28
Base automatically changed from make_ptx_an_enum to master November 27, 2025 09:54
@ImplOfAnImpl
Fork detection script. Rename from_height parameter in chainstate dum…
a59b500 
…per. Chainstate no longer prints "Stale block received" to debug log (this was meant to be used by the fork detector).
@ImplOfAnImpl
Fix spurious failure in the unsupported_message test in p2p
fd3e62d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

@OBorce OBorce Awaiting requested review from OBorce OBorce is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ImplOfAnImpl