Open
Conversation
a002eb6 to
638f00a
Compare
Member
|
Hi Peter! Could you fix the Rubocop errors so that the workflow can fail when running the test suite? 😬 Sorry about that! |
638f00a to
f7d0955
Compare
Author
|
@remi Done! |
pboling
commented
Oct 27, 2023
f7d0955 to
04fc02c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite continues to not work at all, due to:
It is the same error with both MySQL and PostgreSQL drivers.
But this is a big step in the direction of getting it working again.
I'm hoping this is step one on a path to getting the gem working with
json_schemerv2!