Fix numerically negative areas leading to infinite loop in dynamic programming#18
Open
jdumas wants to merge 1 commit intomkazhdan:masterfrom
Open
Fix numerically negative areas leading to infinite loop in dynamic programming#18jdumas wants to merge 1 commit intomkazhdan:masterfrom
jdumas wants to merge 1 commit intomkazhdan:masterfrom
Conversation
f051a76 to
4563bbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered some pathological situations where calls to
TriangulateConvexPolygon()would hang forever on some very poorly conditioned inputs. The root cause of the problem seems to beSquaredArea()returning numerically negative< 0values, which cause the dynamic programming cache inMinimalAreaTriangulation::GetTriangulation()to blow up and get into infinite loop or exponential behavior. A simple fix is to clamp the returned values to be>= 0.To reproduce the problem, you can use the following vertices as inputs to
TriangulateConvexPolygon():