fix: merge Extensions in unionCapabilities#9
Merged
Conversation
unionCapabilities merges Experimental map entries from inner variant servers but skips the Extensions field entirely. This means any extension registered via ServerCapabilities.AddExtension on an inner server (e.g. io.modelcontextprotocol/skills) is silently dropped from the front proxy's InitializeResult. Add the same first-wins merge logic for Extensions that already exists for Experimental, and bump go-sdk to v1.4.1 which introduced the Extensions field on ServerCapabilities. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sambhav
force-pushed
the
fix/union-capabilities-extensions
branch
from
9709bcf to
a36e01a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unionCapabilitiesmergesExperimentalmap entries from inner variant servers but skips theExtensionsfield entirely. This means any extension registered viaServerCapabilities.AddExtension()on an inner server (e.g.io.modelcontextprotocol/skills) is silently dropped from the front proxy'sInitializeResult.Extensionsthat already exists forExperimentalgo-sdkto v1.4.1 which introduced theExtensionsfield onServerCapabilitiesunionCapabilitiesextensions mergingTest plan
TestUnionCapabilities_MergesExtensions— verifies first-wins merge semantics for extensionsTestIntegration_ExtensionsAdvertised— verifies extensions registered on inner servers appear in the client'sInitializeResult