jsonrpc2: decode requests with empty method fields#996
Open
Zhang-986 wants to merge 1 commit into
Open
Conversation
Zhang-986
force-pushed
the
codex/stdio-empty-method-error-response
branch
from
a9bbb38 to
7e3c1a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Guideline
This change updates JSON-RPC message decoding to classify any payload with a
methodfield as a request, even when the method value is an empty string.Previously,
DecodeMessageused the decoded method string to distinguish requests from responses. That meant{"jsonrpc":"2.0","id":5,"method":"","params":{}}was decoded as a response because the method string was empty, so stdio servers could fail to send the expected JSON-RPC error response for malformed requests.The implementation now checks whether the
methodfield exists in the raw JSON object before constructing the concrete message type, preserving empty-method requests for normal request handling and error reporting.Fixes #976
Tests:
go test ./internal/jsonrpc2