-
Notifications
You must be signed in to change notification settings - Fork 125
feat(DENG-9467): set up terms_of_use generator #8395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3c4d712 to
901b6d5
Compare
This comment has been minimized.
This comment has been minimized.
901b6d5 to
af0c58a
Compare
This comment has been minimized.
This comment has been minimized.
| FROM | ||
| `{{ project_id }}.{{ app_name }}_derived.{{ table_name }}` | ||
| WHERE | ||
| DATE(submission_timestamp) <= @submission_date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: need to think more about whether this should be <> instead.
This comment has been minimized.
This comment has been minimized.
71782d3 to
46fe809
Compare
This comment has been minimized.
This comment has been minimized.
46fe809 to
ce88134
Compare
This comment has been minimized.
This comment has been minimized.
| -- {{ header }} | ||
| SELECT | ||
| submission_timestamp, | ||
| metrics.uuid.messaging_system_client_id AS legacy_telemetry_client_id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soGaussian @irrationalagent , should client_id also be included in this query?
| name: messaging_surface | ||
| type: STRING | ||
| description: | | ||
| TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soGaussian could you help me come up with accurate description of this field?
edd716d to
2e9b83e
Compare
…rior to the join, and add sample_id
2e9b83e to
63cbf9b
Compare
| IF( | ||
| _previous.client_id IS NULL | ||
| OR ( | ||
| (_current.terms_of_use_version_accepted <> _previous.terms_of_use_version_accepted) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add an additional check here to make sure we're not overwriting "future" entries?
This comment has been minimized.
This comment has been minimized.
… of submission_timestamp
Integration report for "fix: update terms_of_use_status schema to use submission_date instead of submission_timestamp"
|
feat(DENG-9467): set up terms_of_use generator
Description
This adds a new generator for generating ToS related queries for 3 different applications:
This is to support ToS related analysis.