fix(format): Update qualify_table_references_in_file() to work with newer sqlglot versions (DENG-7005)
#8411
+107
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccount for subdirectories now being used.
sean-rose
changed the title
qualify_table_references_in_file() to work with newer sqlgot versions (DENG-7005)qualify_table_references_in_file() to work with newer sqlglot versions (DENG-7005)
This comment has been minimized.
This comment has been minimized.
scholtzan
approved these changes
Nov 10, 2025
…` statements for ignoring table references created in the query itself.
…ORMATION_SCHEMA-fix
This comment has been minimized.
This comment has been minimized.
Integration report for "test(dependency): Add
|
scholtzan
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting in
sqlglotv25.29.0INFORMATION_SCHEMAview identifiers are parsed differently (tobymao/sqlglot#4336), which didn't work with our existingqualify_table_references_in_file()function logic.@BenWu came up with this workaround which allows us to upgrade to the latest
sqlglotv27.29.0, and I've just put the finishing touches on it by skipping qualifying references in files where Jinja expressions are being used for table/view IDs, and working around othersqlglotbreaking changes.Related Tickets & Documents
Reviewer, please follow this checklist