Skip to content

Conversation

@codemist
Copy link
Collaborator

References:

Jira: MNTOR-5066
Figma:

Description

This PR begins the process of removing all data-broker–related information from the front end while minimizing changes to the backend as much as possible. I started with the Dashboard and am working outward from there, since everything is deeply connected and any component referencing OneRepScanResultRow or related OneRep types needs to be carefully unraveled.

I could be wrong here (and also because we didn't really formally decide on a protocol for the FE removal) but because of the amount of prop drilling and cross-component coupling, doing this in tiny incremental PRs each removal step tends to cascade into linting issues, build errors, or broken types. Instead, this PR represents the first major chunk in a slow, deliberate phase-out. It should be reviewed in sections, and it will definitely require a thorough regression test.

The overall goal is to steadily strip out all OneRep/data-broker UI surfaces without destabilizing unrelated areas of the app. Subsequent PRs will continue this clean-up process once this foundation is in place.

Screenshot (if applicable)

Not applicable.

How to test

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, I've checked that it still works with the flag both on, and with the flag off.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@codemist codemist requested a review from Vinnl November 26, 2025 19:04
@Vinnl Vinnl removed their request for review November 27, 2025 15:15
@Vinnl
Copy link
Collaborator

Vinnl commented Nov 27, 2025

As just discussed: I've unassigned myself as a reviewer for now, as you can focus on removing everything that's related (backend as well), and then re-assign me when the checks succeed and it's ready for review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants