-
-
Notifications
You must be signed in to change notification settings - Fork 14
Add PulseAudio audio device
#18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cargo.toml
Outdated
| ] | ||
|
|
||
| [target.'cfg(target_os = "linux")'.dependencies] | ||
| # TODO: make this dependencies optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a feature for PulseAudio, alsa should be the default backend because the current implementation that uses it is well tested. While this implementation is new and needs to be tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added pulse feature and also alsa feature to make the alsa-sys dependency optional. This is not necessary, but it's convenient for those who want to compile pulse only
|
The code looks good, however there's this error in the CI: |
@mrDIMAS It's done |
|
I've published 2.0.0 with your changes. |
It would be great if the library supported PulseAudio too, I propose to add this with my implementation.
It also needs a way to select the desired implementation. I think the simplest approach is to add a
pulsefeature that disables ALSA support and selects PulseAudio. The pulse would be a great default choice imho. So, there's also the option of adding analsafeature instead.