Skip to content

Conversation

@nanoqsh
Copy link
Contributor

@nanoqsh nanoqsh commented Nov 13, 2025

It would be great if the library supported PulseAudio too, I propose to add this with my implementation.

It also needs a way to select the desired implementation. I think the simplest approach is to add a pulse feature that disables ALSA support and selects PulseAudio. The pulse would be a great default choice imho. So, there's also the option of adding an alsa feature instead.

Cargo.toml Outdated
]

[target.'cfg(target_os = "linux")'.dependencies]
# TODO: make this dependencies optional
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a feature for PulseAudio, alsa should be the default backend because the current implementation that uses it is well tested. While this implementation is new and needs to be tested.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added pulse feature and also alsa feature to make the alsa-sys dependency optional. This is not necessary, but it's convenient for those who want to compile pulse only

@mrDIMAS
Copy link
Owner

mrDIMAS commented Nov 14, 2025

The code looks good, however there's this error in the CI: error: unexpected cfg condition value: impl-default. Could you please fix it?

@nanoqsh
Copy link
Contributor Author

nanoqsh commented Nov 14, 2025

The code looks good, however there's this error in the CI: error: unexpected cfg condition value: impl-default. Could you please fix it?

@mrDIMAS It's done

@mrDIMAS mrDIMAS merged commit 704d0b6 into mrDIMAS:main Nov 14, 2025
9 checks passed
@mrDIMAS
Copy link
Owner

mrDIMAS commented Nov 15, 2025

I've published 2.0.0 with your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants