Skip to content

chore: pin actionlint and unblock static checks#337

Merged
mrlunchbox777 merged 8 commits into
mainfrom
chore/static-checks-actionlint-pin
May 13, 2026
Merged

chore: pin actionlint and unblock static checks#337
mrlunchbox777 merged 8 commits into
mainfrom
chore/static-checks-actionlint-pin

Conversation

@mrlunchbox777
Copy link
Copy Markdown
Owner

Summary

  • Pin rhysd/actionlint in static checks workflow to a resolvable tag (v1.7.12) so the actionlint job can start.
  • Add a temporary SHELLCHECK_EXCLUDES list in CI to unblock shell static checks while legacy script warnings are cleaned up.
  • Keep follow-up work explicitly tracked for both exclude cleanup and Actions allowlist policy alignment.

Related

Notes

  • Repos/orgs using restricted Actions allowlists may need to allow rhysd/actionlint@v1.7.12 for this workflow to run.

@github-actions github-actions Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. changes/meta .github file changes labels May 13, 2026
@github-actions github-actions Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. changes/documentation Documentation file changes changes/root Root file changes changes/resources Resources file changes and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2026
@github-actions github-actions Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR unblocks CI static checks by pinning actionlint to a specific, resolvable tag and temporarily suppressing known legacy ShellCheck warnings, with a corresponding version bump and changelog entry.

Changes:

  • Pin rhysd/actionlint to v1.7.12 in the static checks workflow.
  • Add a temporary SHELLCHECK_EXCLUDES list and scope shfmt to a reduced set of .sh files to keep CI green while follow-up cleanup is tracked.
  • Bump version to 0.1.30 and document the change in the changelog.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
resources/version.yaml Bumps primary release version to 0.1.30.
bsctl/static/resources/constants.yaml Mirrors version bump to 0.1.30 for fallback/version constants.
CHANGELOG.md Adds 0.1.30 entry describing the CI/workflow changes.
.github/workflows/static-checks.yaml Pins actionlint and introduces temporary ShellCheck/shfmt exclusions to unblock static checks.
.github/workflows/go-coverage-report.yaml Quotes $GITHUB_PATH usage to satisfy shell linting expectations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/static-checks.yaml Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/static-checks.yaml
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@mrlunchbox777 mrlunchbox777 merged commit d51f11e into main May 13, 2026
12 checks passed
@mrlunchbox777 mrlunchbox777 deleted the chore/static-checks-actionlint-pin branch May 13, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes/documentation Documentation file changes changes/meta .github file changes changes/resources Resources file changes changes/root Root file changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants