fix: implement more robust config and tear down bookkeeping #3664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add shutdown method to stop all outputs and release resources - Schedule shutdown with warning if it takes longer than expected
* Cleaning up capture sessions in deinit likely indicates some bookkeeping isn't completing and is likely to obscure rather than fix bugs * Adding a completion handler to config adds a lot of complexity we can avoid and replace with a more correct DispatchGroup (the group doesn't notify until any async audio and location work complete) * Switch existing DispatchTime usage for dropping redundant config calls to a simple monotonic counter that uses an unfair lock * remove didScheduleShutdown as deactivateCameraSession() is safe to call repeatedly
|
@rustle is attempting to deploy a commit to the mrousavy's Team Team on Vercel. A member of the Team first needs to authorize it. |
rustle
changed the title
mrousavy
requested changes
Nov 11, 2025
Owner
mrousavy
left a comment
mrousavy
left a comment
There was a problem hiding this comment.
Thanks for your PR!
Left some comments
rustle
force-pushed
the
fix/shutdown-freeze-ios26
branch
from
cd7d8ff to
eb07d6a
Compare
Author
|
I've added a comment to explain the manual delegate cleanup and made the work in deinit much smaller and synchronous, but if your preference is still to drop those neither are strictly necessary for this PR to work well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is a revision pass on the work done in #3650
Fix the navigation freeze on React Navigation/Fabric by shutting the camera session down deterministically when the view unmounts.
Changes
Instead of introducing a new shutdown method revise use of configure
Tested on
iPhone 12 mini running 18.7.1
Related issues