Fix TypeScript build errors and iOS connection issues#6
Open
andreabadesso wants to merge 1 commit intomsbrogli:masterfrom
Open
Fix TypeScript build errors and iOS connection issues#6andreabadesso wants to merge 1 commit intomsbrogli:masterfrom
andreabadesso wants to merge 1 commit intomsbrogli:masterfrom
Conversation
Frontend: - Add missing updateBridge method to ApiClient interface - Use isWindowSelection() type guard instead of !isFoldedSelection() to properly narrow Selection type excluding FoldedContainerTarget - Add updateBridge stub to mock API iOS: - Remove TerminalPoolService from TerminalViewModel — the shared connection pool caused race conditions when switching sessions (onDisappear/onAppear timing led to stuck "Connecting..." state) - Each terminal now gets its own dedicated TerminalConnection - Fix ClaudeHooksHintIcon showing full-screen popover on iPhone by removing tap interaction from list row icons Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm buildFrontend fixes
updateBridgemethod toApiClientinterface (used inBridgeSettingsPagebut not declared)isWindowSelection()type guard instead of!isFoldedSelection()to properly narrowSelectiontype — the latter doesn't excludeFoldedContainerTargetupdateBridgestub to mock APIiOS fixes
TerminalPoolServiceusage fromTerminalViewModel— the shared connection pool caused race conditions when switching sessions (onDisappear/onAppeartiming led to stuck "Connecting..." state where the WebSocket was disconnected then never properly reconnected)TerminalConnectionClaudeHooksHintIconshowing full-screen popover sheet on iPhone by removing tap/popover from list row icons (keep it only in the tab bar where it makes sense)Test plan
npm run buildpasses without TypeScript errors🤖 Generated with Claude Code