Bugfix in copy_expert method #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be perfectly honest, I'm not exactly sure what the purpose of this change is; it's one commit written by a predecessor who's no longer at our organization. Apparently, though, not setting the _copysize property in this method broke one of our applications. Anyhow, now that I've inherited this codebase, I'm trying to get its various dependencies synced with upstream so we're not maintaining forks.
If this doesn't seem sane or merge-worthy at first glance, I can track down my former colleague and see if I can get a more detailed justification and/or test-case before you merge.