Skip to content

Conversation

@tessstoddard
Copy link
Contributor

@tessstoddard tessstoddard commented Jan 14, 2026

Summary of Changes

  • Adds challenges to recurring p2p transfer model. As well as logic in the P2PTransferController and RecurringP2PTransferController for create and update. Based on these changes here https://gitlab.com/mxtechnologies/mx/gutenberg/-/merge_requests/909
  • Also adds masking to new fields that were adding for P2P Transfers that should be masked. I evaluated the rest of the models and the other sensitive fields were already being masked correctly

Fixes # https://mxcom.atlassian.net/browse/GCU-1187 and https://mxcom.atlassian.net/browse/GCU-1160

Public API Additions/Changes

Just adding challenges and also return 202 if challenges are present

Downstream Consumer Impact

None

How Has This Been Tested?

Published a local version and tested. Verified 202s are returned with challenges and also fields are being masked for path_incoming fields

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@tessstoddard tessstoddard force-pushed the tess/p2p_transfer_challenges branch from ec8514a to 37adff5 Compare January 15, 2026 16:33
@tessstoddard tessstoddard merged commit 17cb1a0 into master Jan 15, 2026
7 checks passed
@tessstoddard tessstoddard deleted the tess/p2p_transfer_challenges branch January 15, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants