Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
==========================================
- Coverage 74.36% 74.20% -0.16%
==========================================
Files 47 47
Lines 2816 2822 +6
==========================================
Hits 2094 2094
- Misses 722 728 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dracos
force-pushed
the
types-endpoint
branch
from
73a438f to
7fddf22
Compare
neprune
left a comment
neprune
left a comment
There was a problem hiding this comment.
Looks good bar the one query. Not sure if it's worth also getting rid of the area-types.html templates in mapit_no and mapit_it.
| max_length=500, unique=True, help_text="A unique code to identify this type of name: eg 'english' or 'iso'") | ||
| description = models.CharField( | ||
| max_length=200, blank=True, help_text="The name of this type of name, eg 'English' or 'ISO Standard'") | ||
| objects = models.Manager() |
There was a problem hiding this comment.
Was this an intentional removal? Can see this is referenced get_or_create_with_name in models.py at least. I don't think it gets inherited from TypeModel either.
There was a problem hiding this comment.
models.Manager is the default as far as I'm aware. https://docs.djangoproject.com/en/5.2/topics/db/managers/ - "By default, Django adds a Manager with the name objects to every Django model class."
2 participants
No description provided.