Skip to content

fix: detect WireGuard handshake when nanosecond component is zero #6187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cvl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: detect WireGuard handshake when nanosecond component is zero #6187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions services/wireguard/endpoint/userspace/device_parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,10 @@ func (dp *deviceParser) peerParse(key, value string) {
dp.hsNano = dp.parseInt(value)

// Assume that we've seen both seconds and nanoseconds and populate this
// field now. However, if both fields were set to 0, assume we have never
// had a successful handshake with this peer, and return a zero-value
// time.Time to our callers.
if dp.hsSec > 0 && dp.hsNano > 0 {
// field now. Only skip if BOTH are 0 (no handshake ever occurred).
// Note: either field alone can be 0 for a valid handshake (e.g. nsec=0
// when the handshake happened at an exact second boundary).
if dp.hsSec > 0 || dp.hsNano > 0 {
p.LastHandshakeTime = time.Unix(int64(dp.hsSec), int64(dp.hsNano))
}
case "tx_bytes":
Expand Down