fix: Add namespace support for AppRole auth#38
Merged
wRLSS merged 3 commits intonamecheap:masterfrom Jul 25, 2025
Merged
Conversation
worg
force-pushed
the
hp/add-approle-namespace
branch
2 times, most recently
from
8c780f5 to
7fcfac4
Compare
Contributor
Author
|
Hello @b1ff, sorry to bother can you take a look at this? |
Contributor
|
@worg please provide additional test coverage for the change. The red build without docker-compose I will handle |
worg
force-pushed
the
hp/add-approle-namespace
branch
from
ba094d8 to
d791fb2
Compare
Contributor
Author
|
@wRLSS done |
Contributor
|
@worg please update from master branch, pipeline should be fixed |
worg
force-pushed
the
hp/add-approle-namespace
branch
from
05d8806 to
d37d75a
Compare
Signed-off-by: Hiram J. Pérez <hi@worg.xyz>
Signed-off-by: Hiram J. Pérez <hi@worg.xyz>
Signed-off-by: Hiram J. Pérez <hi@worg.xyz>
worg
force-pushed
the
hp/add-approle-namespace
branch
from
d37d75a to
1aca7f1
Compare
Contributor
Author
wRLSS
approved these changes
Jul 25, 2025
Contributor
|
@worg thanks for contribution, the PR is merged |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #23 but for AppRole auth