Skip to content

Fix LD_LIBRARY_PATH and documentation images with transparency#593

Open
SuhasSrinivasan wants to merge 8 commits intonanoporetech:masterfrom
SuhasSrinivasan:me-img
Open

Fix LD_LIBRARY_PATH and documentation images with transparency#593
SuhasSrinivasan wants to merge 8 commits intonanoporetech:masterfrom
SuhasSrinivasan:me-img

Conversation

@SuhasSrinivasan
Copy link

This PR contains two main changes

  1. Update LD_LIBRARY_PATH export format for compatibility.
    As discussed in Documentation for libtorch installation #491
  2. Having a white background makes it easy to view the image in Dark Mode (OS/Browser/Site) and for Visual Accessibility.
    Fix for issue Black lines and black text are not visible in Open Chromatin Illustration #572
    2.a. Open Chromatin illustration
    2.b. Methylation Entropy illustration

Closing the earlier separate PRs #569 and #573 since current PR encapsulates all changes.

Copilot AI review requested due to automatic review settings March 12, 2026 22:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates runtime setup notes for the tch/libtorch build and adjusts documentation images to improve visibility in dark mode / non-white backgrounds.

Changes:

  • Update LD_LIBRARY_PATH export logic to preserve an existing value while appending the libtorch library directory.
  • Switch two docs pages to reference “no alpha” (non-transparent) versions of illustrations.
  • Add a new “no alpha” entropy illustration image.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

File Description
docs/intro_open_chromatin.html Switches the open chromatin illustration to a non-transparent PNG.
docs/intro_entropy.html Switches the methylation entropy illustration to a non-transparent PNG.
docs/images/me_no_alpha.png Adds a non-transparent version of the methylation entropy illustration.
BUILD_NOTES_tch.txt Makes LD_LIBRARY_PATH export append-safe for compatibility with existing user environments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Updated the image to show chromatin accessibility treatment without transparency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants