Fix LD_LIBRARY_PATH and documentation images with transparency#593
Open
SuhasSrinivasan wants to merge 8 commits intonanoporetech:masterfrom
Open
Fix LD_LIBRARY_PATH and documentation images with transparency#593SuhasSrinivasan wants to merge 8 commits intonanoporetech:masterfrom
SuhasSrinivasan wants to merge 8 commits intonanoporetech:masterfrom
Conversation
Update LD_LIBRARY_PATH export format for compatibility.
There was a problem hiding this comment.
Pull request overview
This PR updates runtime setup notes for the tch/libtorch build and adjusts documentation images to improve visibility in dark mode / non-white backgrounds.
Changes:
- Update
LD_LIBRARY_PATHexport logic to preserve an existing value while appending the libtorch library directory. - Switch two docs pages to reference “no alpha” (non-transparent) versions of illustrations.
- Add a new “no alpha” entropy illustration image.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/intro_open_chromatin.html | Switches the open chromatin illustration to a non-transparent PNG. |
| docs/intro_entropy.html | Switches the methylation entropy illustration to a non-transparent PNG. |
| docs/images/me_no_alpha.png | Adds a non-transparent version of the methylation entropy illustration. |
| BUILD_NOTES_tch.txt | Makes LD_LIBRARY_PATH export append-safe for compatibility with existing user environments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Improves readability
Updated the image to show chromatin accessibility treatment without transparency.
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two main changes
As discussed in Documentation for libtorch installation #491
Fix for issue Black lines and black text are not visible in Open Chromatin Illustration #572
2.a. Open Chromatin illustration
2.b. Methylation Entropy illustration
Closing the earlier separate PRs #569 and #573 since current PR encapsulates all changes.