Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/NATS.Client.JetStream/NatsJSContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,12 @@ public async ValueTask<NatsResult<PubAckResponse>> TryPublishAsync<T>(
headers ??= new NatsHeaders();
headers["Nats-Expected-Last-Subject-Sequence"] = opts.ExpectedLastSubjectSequence.ToString();
}

if (opts.ExpectedLastSubjectSequenceSubject != null)
{
headers ??= new NatsHeaders();
headers["Nats-Expected-Last-Subject-Sequence-Subject"] = opts.ExpectedLastSubjectSequenceSubject;
}
}

opts ??= NatsJSPubOpts.Default;
Expand Down Expand Up @@ -301,6 +307,12 @@ public async ValueTask<NatsJSPublishConcurrentFuture> PublishConcurrentAsync<T>(
headers ??= new NatsHeaders();
headers["Nats-Expected-Last-Subject-Sequence"] = opts.ExpectedLastSubjectSequence.ToString();
}

if (opts.ExpectedLastSubjectSequenceSubject != null)
{
headers ??= new NatsHeaders();
headers["Nats-Expected-Last-Subject-Sequence-Subject"] = opts.ExpectedLastSubjectSequenceSubject;
}
}

opts ??= NatsJSPubOpts.Default;
Expand Down
3 changes: 3 additions & 0 deletions src/NATS.Client.JetStream/NatsJSOpts.cs
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,9 @@ public record NatsJSPubOpts : NatsPubOpts
// lss *uint64 // Expected last sequence per subject
public ulong? ExpectedLastSubjectSequence { get; init; }

// Expected last sequence subject filter (allows wildcard subjects)
public string? ExpectedLastSubjectSequenceSubject { get; init; }

// Publish retries for NoResponders err.
// rwait time.Duration // Retry wait between attempts
public TimeSpan RetryWaitBetweenAttempts { get; init; } = TimeSpan.FromMilliseconds(250);
Expand Down
58 changes: 58 additions & 0 deletions tests/NATS.Client.JetStream.Tests/PublishTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,64 @@ public async Task Publish_test(NatsRequestReplyMode mode)
}
}

[SkipIfNatsServer(versionEarlierThan: "2.12")]
public async Task Publish_expected_last_subject_sequence_subject_test()
{
await using var nats = new NatsConnection(new NatsOpts
{
Url = _server.Url,
ConnectTimeout = TimeSpan.FromSeconds(10),
});
await nats.ConnectRetryAsync();
var prefix = _server.GetNextId();

var js = new NatsJSContext(nats);

var cts = new CancellationTokenSource(TimeSpan.FromSeconds(10));

await js.CreateStreamAsync($"{prefix}s1", new[] { $"{prefix}s1.>" }, cts.Token);

// Publish to subject1
var ack1 = await js.PublishAsync(
subject: $"{prefix}s1.filter.subject1",
data: 1,
cancellationToken: cts.Token);
Assert.Null(ack1.Error);

// Publish to subject2
var ack2 = await js.PublishAsync(
subject: $"{prefix}s1.filter.subject2",
data: 2,
cancellationToken: cts.Token);
Assert.Null(ack2.Error);

// Publish to subject1 again, using ExpectedLastSubjectSequenceSubject to check against subject2's last sequence
var ack3 = await js.PublishAsync(
subject: $"{prefix}s1.filter.subject1",
data: 3,
opts: new NatsJSPubOpts
{
ExpectedLastSubjectSequence = ack2.Seq,
ExpectedLastSubjectSequenceSubject = $"{prefix}s1.filter.subject2",
},
cancellationToken: cts.Token);
Assert.Null(ack3.Error);

// Publish with stale sequence for subject2 should fail
var ack4 = await js.PublishAsync(
subject: $"{prefix}s1.filter.subject1",
data: 4,
opts: new NatsJSPubOpts
{
ExpectedLastSubjectSequence = ack1.Seq, // stale sequence
ExpectedLastSubjectSequenceSubject = $"{prefix}s1.filter.subject2",
},
cancellationToken: cts.Token);
Assert.Equal(400, ack4.Error?.Code);
Assert.Equal(10071, ack4.Error?.ErrCode);
Assert.Matches(@"wrong last sequence: \d+", ack4.Error?.Description);
}

[Theory]
[InlineData(NatsRequestReplyMode.Direct)]
[InlineData(NatsRequestReplyMode.SharedInbox)]
Expand Down
Loading