Refactor: pass around record of properties for operation

[thompson-tomo]

This does some basic refactoring to prepare for #871 with the key focus being to pass record of operation properties rather than multiple variables.

As part of this change the following has been introduced:

• Nats{{operation}}Props: which are used to package up the properties and past through the call stack

Potential Breaking changes:

• ReceiveInternalAsync within NatsSubBase has introduced a new overload designed in a backward compatitable way

[mtmk]

can we have these props as structs? we don't want to contribute to GC especially with every publish for example. Also we can't change the public interfaces (haven't seen any yet, but just in case there are changes to them)

[thompson-tomo]

Unfortunately you can't do inheritance with structs and in a couple of locations it takes a base class. in fact the rabbitmq client uses classes for this example https://rabbitmq.github.io/rabbitmq-dotnet-client/api/RabbitMQ.Client.BasicProperties.html but given it is a DTO, a record felt more right to me and it allows properties to be updated after initialisation.

[mtmk]

thanks for this @thompson-tomo had a quick scan through I appreciate your care about the public interface we have to make sure not the break existing dependencies to us. the main comment i'd have is about performance. would be good to run some of the benchmarks and my gut feeling is to have the props as structs rather than classes will probably help.

edit: i just realize it's still WIP but hope it helps anyway

[thompson-tomo]

Agree @mtmk that we need to be careful not to impact existing dependencies hence the new internal methods etc. This is almost done with the main outstanding being review of accessibility modifiers, code comments & the UNKNOWN param scenario.

[thompson-tomo]

@mtmk So it might be difficult to get reliable benchmarks given the current setup is producing such significant variance in results but based on last results & comparing it to a test from when I cleaned up the csproj file. The throughput has increased but at the same time the memory usage also went up. At the same time the allocated memory also sharply rose but not sure if issue due to short test run.