Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 95.64% 96.07% +0.42%
==========================================
Files 10 10
Lines 551 611 +60
==========================================
+ Hits 527 587 +60
Misses 19 19
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for TCP as an alternative protocol for Vault audit log delivery, alongside UDP. It updates configuration options, command-line flags, and documentation to allow users to select between UDP and TCP for audit log transport. The implementation includes validation of the protocol, ensures proper propagation throughout the setup and server commands, and adds comprehensive tests for both protocols. Additionally, integration test infrastructure is updated to facilitate TCP testing with Vault running in Docker.
Protocol support and configuration:
vault.audit_protocoloption (default:udp) to configuration, command-line flags, and environment variables, allowing users to specify eitherudportcpfor audit log delivery. Validation ensures only supported values are accepted. (cmd/root.go,README.md,cmd/root_test.go) (F82499c3L68R68, F82499c3L96R96, F82499c3L112R112, [1] [2] [3] F95df156L67R67)setupandauditServercommands to use the selected protocol in Vault audit device configuration and server listening address. (cmd/setup.go,cmd/auditServer.go) [1] [2] [3] [4]Testing and validation:
cmd/root_test.go,cmd/setup_test.go,cmd/auditServer_test.go) (F95df156L67R67, [1] [2] [3] Fc6ad765L64R64)integration_test.go,Makefile,docker-compose.yml) [1] [2] [3] [4]Documentation updates:
README.mdto document the new protocol option, usage instructions, and Docker integration test requirements. (README.md) [1] [2] [3] [4] [5]Spec tracking:
openspec/changes/archive/2026-02-13-add-tcp-audit-protocol/.openspec.yaml)