-
Notifications
You must be signed in to change notification settings - Fork 52
Add depends property to Mod annotation for conditional entrypoints
#393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hedgehog1029
wants to merge
8
commits into
neoforged:main
Choose a base branch
from
hedgehog1029:feat/mod-entrypoint-depends
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add depends property to Mod annotation for conditional entrypoints
#393
hedgehog1029
wants to merge
8
commits into
neoforged:main
from
hedgehog1029:feat/mod-entrypoint-depends
+72
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fix the located bug, thank you unit testing!
|
|
@hedgehog1029, this PR introduces breaking changes.
|
Technici4n
reviewed
Dec 3, 2025
loader/src/main/java/net/neoforged/fml/javafmlmod/FMLJavaModLanguageProvider.java
Outdated
Show resolved
Hide resolved
Leave it up to the modder whether they specify optional dependencies or not
|
why not add a new mod depency type to mods.toml to impl this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201, alternative to #212
This PR adds the ability to specify entrypoints that will only be loaded if the specified mod ID(s) are present:
This is implemented by checking against the
LoadingModList- entrypoints withdependsmissing from the loading list are filtered out early.We enforce inNo longer enforced, leave it up to developers to choose.validatethat any dependencies specified in the annotation are also specified in the mods.toml - this ensures the mods are loaded in the correct order.Please let me know if this is a sane approach! Otherwise I suppose I'll have to rethink and move the filtering to a later step.
Unit tests have been added to validate the new behaviour.