Skip direct-copying entries starting with maven/
#49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Downloader instance will pick artifacts from that directory through LocalSource#fromResource(). Fixes #48
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #48 by teaching
FatInstallerActionto skip copying JAR entries which begin withmaven/. TheDownloaderinstance will pick artifacts from that directory throughLocalSource#fromResource().This has two side-effects:
maven/that are unused (not declared in the manifests for vanilla and NeoForge) will get skipped over.maven/has a different checksum from the one declared in the manifests (if there is one), the downloader will reject that stored artifact and download it anew.