Adds cache key contributions for referenced NeoForm data #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technici4n
reviewed
Oct 10, 2025
src/main/java/net/neoforged/neoform/runtime/actions/ExternalJavaToolAction.java
Outdated
Show resolved
Hide resolved
Member
I'm a bit confused. Does this fix anything beyond the issues in #86? |
|
🚀 This PR has been released as NeoFormRuntime version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86, and also fixes issues people have been having when they were switching between NeoForm versions in the same Minecraft version (rare, but happened in 1.21.10 with a broken NeoForm version)