Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test inclusion requirements
pytest tests/unit/poller/worker/services -k device(2 tests) after installingnubiain thesuzieqvenv to cover the Junos device cleaner behavior touched by this fix.Related Issue
Fixes #903
Description
Restore Junos EX bootup timestamp extraction by switching
junos-exto the MX normalization, guard_clean_junos_dataagainst missingbootupTimestamp, and treat EX platforms like MX/QFX10K/EVO in the node bootstrapper so single-engine JSON outputs parse correctly.Type of change
New Behavior
Poller successfully parses
bootupTimestampfor EX 14.x devices, and the Junos cleaner no longer raises when the field is absent—EX nodes report boot time in both node metadata and thedeviceservice....
Contrast to Current Behavior
Previously, the EX normalization used the multi-routing-engine JSON path, so
bootupTimestampnever appeared and_clean_junos_datacrashed withKeyError; the node bootstrapper also logged warnings about failing to parse boot time....
Discussion: Benefits and Drawbacks
Benefits: prevents sq-poller crashes on Junos EX, improves resilience across Junos variants, and keeps behavior backward-compatible for other families. No drawbacks observed.
...
Changes to the Documentation
None.
...
Proposed Release Note Entry
Fix Junos EX bootup timestamp parsing so sq-poller no longer fails when
show system uptime | display jsonlacksbootupTimestamp....
Comments
Unit testing was limited to the targeted subset noted above; broader suites were not run.
Double Check
developbranch.developbranch.--signoffapplied