[NAE-2394] - Fields looks editable when switching tabs

[Kovy95]

Description

• fix problem with fields while switching the tabs, add block fields to get data event

Fixes NAE-2394

Dependencies

none

Third party dependencies

• No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

manually

Test Configuration

<Please describe configuration for tests to run if applicable, like program parameters, host OS, VM configuration etc. You can use >

Name	Tested on
OS	LinuxMint 22
Runtime	Node 20.18.0
Dependency Manager	NPM 10.8.2
Framework version	Angular 13.3
Run parameters
Other configuration

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• My changes have been checked, personally or remotely, with @...
• I have commented my code, particularly in hard-to-understand areas
• I have resolved all conflicts with the target branch of the PR
• I have updated and synced my code with the target branch
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes:
  • Lint test
  • Unit tests
  • Integration tests
• I have checked my contribution with code analysis tools:
  • SonarCloud
  • Snyk
• I have made corresponding changes to the documentation:
  • Developer documentation
  • User Guides
  • Migration Guides

Summary by CodeRabbit

• Bug Fixes
  • Task panel now properly blocks fields during reload based on user comparison, ensuring correct access control when task data is refreshed.

[coderabbitai]

Walkthrough

Three component files have been updated to inject a new UserComparatorService dependency and implement user comparison logic during task panel reload. The abstract component now conditionally blocks task fields based on user comparison results before initializing task data.

Changes

Cohort / File(s)	Summary
Service Injection projects/netgrif-components-core/src/lib/panel/task-panel/abstract-task-panel.component.ts, projects/netgrif-components/src/lib/panel/task-panel/task-panel.component.ts	Added UserComparatorService as a new protected constructor dependency in both the abstract and concrete task panel components; updated super() calls to pass the service as an argument.
Test Component Update projects/netgrif-components-core/src/lib/panel/task-panel/abstract-task-panel.component.spec.ts	Added UserComparatorService import and updated test component constructor to inject the new dependency; realigned subsequent parameter positions in the super() call.
Reload Flow Logic projects/netgrif-components-core/src/lib/panel/task-panel/abstract-task-panel.component.ts	Modified the tab reload flow to wrap initialization in a call chain, computing taskShouldBeBlocked via user comparison, and conditionally blocking fields before proceeding with task data initialization.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• [NAE-2217] Single Task View #303: Directly modifies AbstractTaskPanelComponent constructor and dependency injection pattern, indicating related service integration work.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly corresponds to the main change: preventing fields from appearing editable when switching tabs by blocking them based on user comparison logic.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@projects/netgrif-components-core/src/lib/panel/task-panel/abstract-task-panel.component.spec.ts`:
- Around line 219-226: Add a regression spec that injects NAE_TAB_DATA with an
injectedTabData mock exposing tabSelected$ (Subject) and wires the component
under test using the existing constructor/super setup; emit a tabSelected$ event
in the test, stub the GET_DATA response path (the post-GET_DATA callback) to
return task data with blocked fields and set the task editable flag, then assert
the blocked fields remain when _userComparator (UserComparatorService) and
finish permission (finishPolicyService/finishPolicy) indicate success, and
assert the callback forces blocks when _userComparator or finish permission
fails; use spies/mocks on _taskDataService GET/subscribe and on
_userComparator.compare and finishPolicyService.canFinish to drive both success
and failure cases and verify the component’s blocked-field state after the
tabSelected$ emission.

In
`@projects/netgrif-components-core/src/lib/panel/task-panel/abstract-task-panel.component.ts`:
- Around line 148-151: The constructor change in AbstractTaskPanelComponent
added a required _userComparator parameter before existing optional parameters,
breaking positional super(...) calls; restore source-compatibility by moving the
new UserComparatorService parameter to after the existing tail (after
injectedTabData) or obtain the comparator internally (e.g., via injector) so the
public constructor signature (the order of overflowService, _taskForceOpen,
injectedTabData) remains unchanged; update the constructor signature and any use
of _userComparator inside the class accordingly while keeping the original
parameter order for downstream subclasses.
- Around line 200-205: The callback passed to initializeTaskDataFields currently
computes taskShouldBeBlocked and calls
_taskContentService.blockFields(taskShouldBeBlocked), which wipes per-field
block flags; instead, change the logic so you only call
_taskContentService.blockFields(true) when the predicate is true (i.e., task is
missing or user undefined or !_userComparator.compareUsers(...) OR
hasNoFinishPermission()), and do nothing in the false/editable branch so
existing per-field block state from GET_DATA is preserved; update the predicate
to include hasNoFinishPermission() and only invoke blockFields when that
combined predicate is true.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 73424906-33e4-4999-9848-8ee5fcc4078d

📥 Commits

Reviewing files that changed from the base of the PR and between 28679ae and 851d55c.

📒 Files selected for processing (3)

• projects/netgrif-components-core/src/lib/panel/task-panel/abstract-task-panel.component.spec.ts
• projects/netgrif-components-core/src/lib/panel/task-panel/abstract-task-panel.component.ts
• projects/netgrif-components/src/lib/panel/task-panel/task-panel.component.ts

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
25.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud