NETOBSERV-2481 - Create tmp dir

[memodi]

Description

NETOBSERV-2481 - Create tmp dir

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[memodi]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:61e9116

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=61e9116 make commands

or download the updated commands.

[jpinsonneau]

Looks good to me, tested and work fine on my fedora 🥳

Thanks @memodi !

[memodi]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:3ddb2c9

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=3ddb2c9 make commands

or download the updated commands.

[stleerh]

Better to move this out of the if clusterisReady; then block to the last line of the cleanup function since it's not related to the cluster being ready.

Side note: Not sure the check to clusterIsReady is correct, since I don't get the "Unable to connect" text when there is an issue.

[memodi]

Better to move this out of the if clusterisReady; then block to the last line of the cleanup function since it's not related to the cluster being ready.

done in the latest commit.

Side note: Not sure the check to clusterIsReady is correct, since I don't get the "Unable to connect" text when there is an issue.

I think current check is a simple one which doesn't include other possible reasons why CLI may not be able to connect to cluster. Curious, what error do you see when there is an issue with cluster?

[stleerh]

Never mind. It looks like it is detecting when the cluster is not ready.

[stleerh]

/lgtm

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 12.92%. Comparing base (cd920fe) to head (818555f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #415   +/-   ##
=======================================
  Coverage   12.92%   12.92%           
=======================================
  Files          19       19           
  Lines        2438     2438           
=======================================
  Hits          315      315           
  Misses       2099     2099           
  Partials       24       24           

Flag	Coverage Δ
unittests	12.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[memodi]

/cherry-pick release-1.10

[openshift-cherrypick-robot]

@memodi: #415 failed to apply on top of branch "release-1.10":

Applying: create tmp dir
Using index info to reconstruct a base tree...
M	scripts/functions.sh
Falling back to patching base and 3-way merge...
Auto-merging scripts/functions.sh
CONFLICT (content): Merge conflict in scripts/functions.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 create tmp dir

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.