dockerignore

[jpinsonneau]

Description

Improve dockerignore to speed up image build

• reduce unecessary context when building images
• avoid copying sensitive content

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign leandroberetta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[luisjira]

.dockerignore docs mention **/*.go to ignore all files ending with .go anywhere in the build context, including subdirectories.

I think it makes sense to add **/ before the lines that don't have a fixed location in the root directory.

[jpinsonneau]

.dockerignore docs mention **/*.go to ignore all files ending with .go anywhere in the build context, including subdirectories.

I think it makes sense to add **/ before the lines that don't have a fixed location in the root directory.

indeed that would be better ! Thanks for pointing that @luisjira !

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.58%. Comparing base (6613e89) to head (7fd9085).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2197      +/-   ##
==========================================
+ Coverage   73.02%   73.58%   +0.55%     
==========================================
  Files          80       81       +1     
  Lines        9180     9253      +73     
==========================================
+ Hits         6704     6809     +105     
+ Misses       2062     2032      -30     
+ Partials      414      412       -2     

Flag	Coverage Δ
unittests	73.58% <ø> (+0.55%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 13 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jotak]

/ok-to-test

[jotak]

I don't understand why the konflux jobs aren't triggered...
I'd like to make sure the downstream bundle build isn't affected

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:d441692
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-d441692
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-d441692

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:d441692 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-d441692

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-d441692
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[jotak]

Oh, I know, you need to add ".dockerignore".pathChanged() in the on-cell-expression of every tekton jobs