slugify the box (group container) ID too#184
Open
cedricsam wants to merge 1 commit intonewsdev:masterfrom
Open
slugify the box (group container) ID too#184cedricsam wants to merge 1 commit intonewsdev:masterfrom
cedricsam wants to merge 1 commit intonewsdev:masterfrom
Conversation
* If ai2html is used on an Illustrator file name containing invalid element ID characters (anything not alphanumeric/hyphen/underscore), then the group container's ID breaks down. * Intrigued that aside from the top "tktk-box" container ID, all the other IDs on images, text elements, etc., seem properly escaped.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Currently, if you run ai2html on a file with spaces and other non-alphanumeric/hyphen/underscore characters (e.g. named
test-1288px copie. (weird chars) .ai):The fix would escape these invalid characters, like it does on the IDs and class names of img, div elements in the HTML output: