Skip to content

Allow-linkfield-assignments #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rayosborn merged 3 commits into from
Apr 30, 2026
Merged

Allow-linkfield-assignments #260

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c2ae42
Allow values to be assigned to a NXlink using the nxlink attribute
rayosborn Mar 9, 2026
3144da1
Allow assignment of a value to a NXlink with dictionary entry.
rayosborn Mar 22, 2026
ac64d8e
Merge remote-tracking branch 'upstream/main' into allow-linkfield-ass…
rayosborn Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/nexusformat/nexus/tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4943,10 +4943,11 @@ def __setitem__(self, key, value):
elif isinstance(value, NXlink):
raise NeXusError(
"Cannot assign an NXlink to an existing group entry")
elif isinstance(group.entries[key], NXlink):
raise NeXusError("Cannot assign values to an NXlink")
elif group.entries[key].is_linked():
raise NeXusError("Cannot modify an item in linked group")
elif isinstance(group.entries[key], NXlink):
group.entries[key].nxlink = value
return
group.entries[key].nxdata = value
if isinstance(value, NXfield):
group.entries[key]._setattrs(value.attrs)
Expand Down Expand Up @@ -5975,6 +5976,16 @@ def __setattr__(self, name, value):
object.__setattr__(self, name, value)
elif self.is_external():
raise NeXusError("Cannot modify an external link")
elif name == 'nxlink':
obj = self.nxlink
if isinstance(obj, NXfield):
if obj._group is not None:
obj._group[obj.nxname] = value
else:
obj.nxdata = value
obj.update()
else:
raise NeXusError("Cannot modify a linked group")
else:
try:
self.nxlink.setattr(name, value)
Expand Down
Loading