Add functions to get 3D krypton maps#948
Merged
Merged
Conversation
gonzaponte
requested changes
Dec 22, 2025
gonzaponte
requested changes
Jan 23, 2026
Collaborator
gonzaponte
left a comment
gonzaponte
left a comment
There was a problem hiding this comment.
More comments. We will need to build up a bit more testing and put everything together in a city.
Collaborator
gonzaponte
requested changes
Apr 8, 2026
Collaborator
gonzaponte
left a comment
gonzaponte
left a comment
There was a problem hiding this comment.
another round of comments
gonzaponte
reviewed
May 7, 2026
Collaborator
gonzaponte
left a comment
gonzaponte
left a comment
There was a problem hiding this comment.
A few cosmetic changes and we are done. We will rewrite the history together to reduce the number of commits.
gonzaponte
reviewed
May 8, 2026
gonzaponte
reviewed
May 8, 2026
mcidlaso
force-pushed
the
ICAROS_3D
branch
4 times, most recently
from
9091882 to
526119a
Compare
gonzaponte
approved these changes
May 20, 2026
Collaborator
gonzaponte
left a comment
gonzaponte
left a comment
There was a problem hiding this comment.
The 3D version of our beloved Kr maps. An important addition developed with peras, reasonably tested and validated externally. Good job!
Since esmeralda performs energy corrections, there is no guarantee that the energy before and after esmeralda is the same
Skip some tests that were using temporal correction maps. Remove test for normalization strategies since we already have tests for normalization methods.
The map is defined using x,y,dt, so we need to convert DT to Z afterwards.
Since apply correction map function is done in place, df_selected and df_corr end up having the same Ec and Ec2 columns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These scripts contain functions to: