Replace grep -P with grep -E to avoid illegal instruction on non-AVX … #7052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
grep -Ptriggers PCRE JIT which depends on AVX CPU instructions. On systems without AVX(for example many VMware ESXi hosts and older Xeon CPUs), this results in a crash during
Talk relay startup:
This prevents the Talk High Performance Backend from running on those environments.
What this PR changes
Replaces:
with:
in
Containers/talk/start.sh.Why this works
grep -Euses the POSIX Extended Regular Expression engine, which:This makes the script compatible with a wider range of hardware.
Result
Talk relay startup now works correctly on:
There is:
Testing
Verified on: